[Button] Reduce space between chevron icon and provided icon when icon-only #11985
+248
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chloerice
force-pushed
the
reduce-spacing-in-iconOnly-disclosure-Buttons
branch
4 times, most recently
from
5027e31
to
5c1e608
Compare
chloerice
changed the title
chloerice
force-pushed
the
reduce-spacing-in-iconOnly-disclosure-Buttons
branch
from
5c1e608
to
5938e77
Compare
|
/snapit |
|
🫰✨ Thanks @chloerice! Your snapshot has been published to npm. Test the snapshot by updating your "@shopify/polaris": "0.0.0-snapshot-20240506211703" |
|
Needs to be moved into correct repo |
|
@chloerice, there's a note that this needs to be moved into the correct repo. Can you please specify next steps for the new QC developers? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
There's too much spacing between provided icons and the chevron icon rendered in icon-only disclosure buttons. When laid out in a toolbar like the RTE's, the chevrons look like they're separate buttons. The primary use case in admin for icon-only disclosures is the rich text editor, which in /products is using a custom button so they can tighten this gap, but it should be done at the system level.
WHAT is this pull request doing?
This PR tightens the spacing between the
ButtoniconanddisclosureSVGs when icon-only.How to 🎩
🖥 Local development instructions
🗒 General tophatting guidelines
📄 Changelog guidelines
🎩 checklist
Updated the component'sREADME.mdwith documentation changesTophatted documentationchanges in the style guide